Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19528/3/source/kudu/build.sh File source/kudu/build.sh: http://gerrit.cloudera.org:8080/#/c/19528/3/source/kudu/build.sh@125 PS3, Line 125: # Set JAVA_HOME to the system java. Kudu has a bunch of heuristics for trying to > I can remove this with the JDK 8 we ended up with. Done http://gerrit.cloudera.org:8080/#/c/19528/3/source/python/build.sh File source/python/build.sh: http://gerrit.cloudera.org:8080/#/c/19528/3/source/python/build.sh@58 PS3, Line 58: wrap $LOCAL_INSTALL/bin/python -c 'import bz2; import readline; from urllib2 import HTTPSHandler; from httplib import HTTPConnection' > This and the thrift/build.sh could be handled in a different patch. Done -- To view, visit http://gerrit.cloudera.org:8080/19528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d Gerrit-Change-Number: 19528 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 17:35:15 +0000 Gerrit-HasComments: Yes
