Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19554 )
Change subject: IMPALA-11952 (part 4): Fix odds and ends: Octals, long, lambda, etc. ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/19554/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19554/4//COMMIT_MSG@10 PS4, Line 10: - Octals constants need to start with 0o rather than just 0 nit: I'd say "Octal constants need ..." http://gerrit.cloudera.org:8080/#/c/19554/4//COMMIT_MSG@11 PS4, Line 11: - Long constants are not supports (i.e. numbers ending with L) nit: supported -- To view, visit http://gerrit.cloudera.org:8080/19554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie027a50ddf6a2a0db4b34ec9b49484ce86947f20 Gerrit-Change-Number: 19554 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 21:59:47 +0000 Gerrit-HasComments: Yes
