Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19555 )
Change subject: IMPALA-11953: Declare num_trues and num_falses in TIntermediateColumnStats as optional ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/19555/1/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/19555/1/common/thrift/CatalogObjects.thrift@219 PS1, Line 219: // Estimated number of true and false value for boolean type : 5: required i64 num_trues : 6: required i64 num_falses > TColumnStats is not serialized into external storage (like TIntermediateCol Yeah, you're right. It is map to org.apache.hadoop.hive.metastore.api.BooleanColumnStatsData, and that has always have numTrues and numFalse. https://github.com/apache/hive/blob/4784df9a186733eae1794078bacfd610cdcfee09/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L473-L474 Keeping this required should be OK. -- To view, visit http://gerrit.cloudera.org:8080/19555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f74d5d0676e7ce9eb4ea8061a15610846db3ca5 Gerrit-Change-Number: 19555 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 28 Feb 2023 02:00:13 +0000 Gerrit-HasComments: Yes
