Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19557 )
Change subject: IMPALA-11948: Remove operation logging from getCatalogServerMetrics ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19557/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19557/1//COMMIT_MSG@11 PS1, Line 11: is Nit: are http://gerrit.cloudera.org:8080/#/c/19557/1/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/19557/1/fe/src/main/java/org/apache/impala/common/JniUtil.java@150 PS1, Line 150: silent Could be 'silentStartAndFinish' as not all operations are silent. http://gerrit.cloudera.org:8080/#/c/19557/1/fe/src/main/java/org/apache/impala/common/JniUtil.java@206 PS1, Line 206: public static OperationLog logOperation(String methodName, String shortDescription) { 'logOperation()' and 'logOperationSilent()' only differ in the 'silent' parameter they pass to the constructor. Could extract the function body to a separate private helper function that takes the boolean as a parameter and these two public functions could call the helper with the appropriate parameter. -- To view, visit http://gerrit.cloudera.org:8080/19557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd01e9f42ccc6a4adce41caf8884ea3c2c781452 Gerrit-Change-Number: 19557 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:44:22 +0000 Gerrit-HasComments: Yes
