Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18824 )
Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18824/10/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: http://gerrit.cloudera.org:8080/#/c/18824/10/be/src/exec/exchange-node.cc@133 PS10, Line 133: nit: remove line http://gerrit.cloudera.org:8080/#/c/18824/10/be/src/runtime/sorted-run-merger.cc File be/src/runtime/sorted-run-merger.cc: http://gerrit.cloudera.org:8080/#/c/18824/10/be/src/runtime/sorted-run-merger.cc@77 PS10, Line 77: Status We always return OK, so the Status could be void instead -- To view, visit http://gerrit.cloudera.org:8080/18824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic35c7460bdbd54b8ec5872a83680e2f41ceae9fd Gerrit-Change-Number: 18824 Gerrit-PatchSet: 10 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Tue, 28 Feb 2023 15:32:26 +0000 Gerrit-HasComments: Yes
