Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 )
Change subject: IMPALA-9551: Allow mixed complex types in select list ...................................................................... Patch Set 16: (9 comments) I disabled zipping unnest with mixed complex types as getting it to work well with views and WHERE predicates is difficult. I'll try to do it in a later patch. http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/runtime/complex-value-writer.inline.h File be/src/runtime/complex-value-writer.inline.h: http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/runtime/complex-value-writer.inline.h@90 PS15, Line 90: struct_slot_desc.children_tuple_descriptor(); > nit: +2 indentation Done http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/runtime/complex-value-writer.inline.h@116 PS15, Line 116: reinterpret_cast<CollectionValue*>(child); > +2 Done http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/runtime/complex-value-writer.inline.h@118 PS15, Line 118: child_slot_desc.children_tuple_descriptor(); > +2 Done http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/runtime/complex-value-writer.inline.h@236 PS15, Line 236: children_item_tuple_desc->slots(); > +2 Done http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/19322/15/be/src/service/hs2-util.cc@390 PS15, Line 390: static_cast<const SlotRef&>(scalar_expr).GetSlotDescriptor(); > +2 indentation Done http://gerrit.cloudera.org:8080/#/c/19322/15/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/19322/15/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@311 PS15, Line 311: > else if? Done http://gerrit.cloudera.org:8080/#/c/19322/15/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@417 PS15, Line 417: // The path can be null in the case of the sorting tuple. > nit, here and next rows: indentation Done http://gerrit.cloudera.org:8080/#/c/19322/15/testdata/workloads/functional-query/queries/QueryTest/mixed-collections-and-structs.test File testdata/workloads/functional-query/queries/QueryTest/mixed-collections-and-structs.test: http://gerrit.cloudera.org:8080/#/c/19322/15/testdata/workloads/functional-query/queries/QueryTest/mixed-collections-and-structs.test@257 PS15, Line 257: sub.arr_contai > If we look at it strictly this is not zipping unnest, just simply unnest, a In this patch I disallowed zipping unnest with mixed complex types. http://gerrit.cloudera.org:8080/#/c/19322/15/testdata/workloads/functional-query/queries/QueryTest/mixed-collections-and-structs.test@387 PS15, Line 387: 2-12"],null]' > Can you also add one where different view levels have where conditions on t Not done yet, will do in a following patch. -- To view, visit http://gerrit.cloudera.org:8080/19322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I476d98884b5fd192dfcd4feeec7947526aebe993 Gerrit-Change-Number: 19322 Gerrit-PatchSet: 16 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 01 Mar 2023 17:00:17 +0000 Gerrit-HasComments: Yes
