Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19569 )

Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), 
regr_intercept() and regr_r2()
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc@442
PS1, Line 442: DoubleVal AggregateFunctions::RegrSlopeGetValue(FunctionContext* 
ctx, const StringVal& src) {
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc@457
PS1, Line 457: DoubleVal AggregateFunctions::RegrSlopeFinalize(FunctionContext* 
ctx, const StringVal& src) {
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc@468
PS1, Line 468: DoubleVal 
AggregateFunctions::RegrInterceptGetValue(FunctionContext* ctx, const 
StringVal& src) {
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc@486
PS1, Line 486: DoubleVal 
AggregateFunctions::RegrInterceptFinalize(FunctionContext* ctx, const 
StringVal& src) {
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc@692
PS1, Line 692: DoubleVal AggregateFunctions::Regr_r2GetValue(FunctionContext* 
ctx, const StringVal& src) {
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19569/1/be/src/exprs/aggregate-functions-ir.cc@712
PS1, Line 712: DoubleVal AggregateFunctions::Regr_r2Finalize(FunctionContext* 
ctx, const StringVal& src) {
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/19569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6bd84ae3e0c02ec924c30183308123b951caa3
Gerrit-Change-Number: 19569
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 02 Mar 2023 19:53:53 +0000
Gerrit-HasComments: Yes

Reply via email to