Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19572 )
Change subject: IMPALA-11960: Fix constant propagation from TIMESTAMP to DATE ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19572/2/fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java File fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java: http://gerrit.cloudera.org:8080/#/c/19572/2/fe/src/main/java/org/apache/impala/analysis/ConstantPredicateHandler.java@179 PS2, Line 179: if (newOp == BinaryPredicate.Operator.LT) { Will this change of operand be performed for every type? Shouldn't it only be done for the TIMESTAMP/DATE case? -- To view, visit http://gerrit.cloudera.org:8080/19572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1938bf5e91057b220daf8a1892940f674aac3d68 Gerrit-Change-Number: 19572 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 03 Mar 2023 14:25:23 +0000 Gerrit-HasComments: Yes
