Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19499 )
Change subject: IMPALA-11911: Fix NULL argument handling in Hive GenericUDFs ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19499/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19499/4//COMMIT_MSG@22 PS4, Line 22: Most Can we say "all except for those that specifically check that if an exception is thrown then the result is NULL"? http://gerrit.cloudera.org:8080/#/c/19499/3/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java: http://gerrit.cloudera.org:8080/#/c/19499/3/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java@79 PS3, Line 79: private DeferredObject deferredNullParameter_; > Actually not done: Ok. http://gerrit.cloudera.org:8080/#/c/19499/3/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java File fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java: http://gerrit.cloudera.org:8080/#/c/19499/3/fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java@408 PS3, Line 408: errMsgs.add("Expected string: " + Bytes.toString(expectedBytes)); > I think that printing both forms can be useful for special characters, so I Ok. -- To view, visit http://gerrit.cloudera.org:8080/19499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53238612f4037572abb6d2cc913dd74ee830a9c9 Gerrit-Change-Number: 19499 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 03 Mar 2023 15:04:59 +0000 Gerrit-HasComments: Yes
