Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19484 )
Change subject: IMPALA-11822: Optimize the Refresh/Invalidate event processing by skipping unnecessary events ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@301 PS4, Line 301: final TopicMode topicMode_; > After checking more scenarios, I realized this map could lead to mem leak i Ack. I'll use EventId instead of Event time to overcome the clock skew issue. http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2692 PS4, Line 2692: } > We should remove the map item before returning here. Ack http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2702 PS4, Line 2702: Table newTable = addIncompleteTable(dbName, tblName, > Is it possible if the db is not in the catalog cache but somehow we have co Ack http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3882 PS4, Line 3882: > If the partitionName doesn't exist in the keys, it's also possible that the Ack http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/19484/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2534 PS4, Line 2534: > nit: "lastRefreshTime" might be more clear Ack -- To view, visit http://gerrit.cloudera.org:8080/19484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I905957683a96c3ea01ab4bf043d6658ce37b7574 Gerrit-Change-Number: 19484 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 12:25:17 +0000 Gerrit-HasComments: Yes
