Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19592 )
Change subject: IMPALA-11977: Fix Python 3 broken imports and object model differences ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/19592/1/testdata/common/widetable.py File testdata/common/widetable.py: http://gerrit.cloudera.org:8080/#/c/19592/1/testdata/common/widetable.py@55 PS1, Line 55: > flake8: E271 multiple spaces after keyword Done http://gerrit.cloudera.org:8080/#/c/19592/1/testdata/common/widetable.py@55 PS1, Line 55: > flake8: E201 whitespace after '[' Done http://gerrit.cloudera.org:8080/#/c/19592/1/testdata/common/widetable.py@104 PS1, Line 104: > flake8: E201 whitespace after '[' Done http://gerrit.cloudera.org:8080/#/c/19592/1/tests/comparison/cluster.py File tests/comparison/cluster.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/comparison/cluster.py@50 PS1, Line 50: from urllib.parse import urlparse > flake8: E402 module level import not at top of file Switched to different workaround http://gerrit.cloudera.org:8080/#/c/19592/1/tests/custom_cluster/test_saml2_sso.py File tests/custom_cluster/test_saml2_sso.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/custom_cluster/test_saml2_sso.py@30 PS1, Line 30: import urllib.parse > flake8: E402 module level import not at top of file Reworked this to use a different workaround http://gerrit.cloudera.org:8080/#/c/19592/1/tests/custom_cluster/test_saml2_sso.py@31 PS1, Line 31: import urllib.request > flake8: E402 module level import not at top of file Done http://gerrit.cloudera.org:8080/#/c/19592/1/tests/custom_cluster/test_saml2_sso.py@38 PS1, Line 38: class NoRedirection(urllib.request.HTTPErrorProcessor): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/19592/1/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/hs2/test_hs2.py@34 PS1, Line 34: from urllib.request import urlopen > flake8: E402 module level import not at top of file Switched to a different workaround http://gerrit.cloudera.org:8080/#/c/19592/1/tests/hs2/test_json_endpoints.py File tests/hs2/test_json_endpoints.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/hs2/test_json_endpoints.py@27 PS1, Line 27: from urllib.request import urlopen > flake8: E402 module level import not at top of file Switched to different workaround http://gerrit.cloudera.org:8080/#/c/19592/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/shell/test_shell_interactive.py@99 PS1, Line 99: ) > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/19592/1/tests/statestore/test_statestore.py File tests/statestore/test_statestore.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/statestore/test_statestore.py@32 PS1, Line 32: import urllib.request > flake8: E402 module level import not at top of file Switched to different workaround http://gerrit.cloudera.org:8080/#/c/19592/1/tests/util/filesystem_base.py File tests/util/filesystem_base.py: http://gerrit.cloudera.org:8080/#/c/19592/1/tests/util/filesystem_base.py@24 PS1, Line 24: class BaseFilesystem(with_metaclass(ABCMeta, object)): > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/19592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I988ae6c139142678b0d40f1f4170b892eabf25ee Gerrit-Change-Number: 19592 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 23:20:49 +0000 Gerrit-HasComments: Yes
