Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19505 )
Change subject: IMPALA-11223: Use unique id to create codegen instances ...................................................................... IMPALA-11223: Use unique id to create codegen instances When startup flag asm_module_dir is set, impalad will dump the codegen disassembly to files under that folder. The file name is "id.asm" in which "id" is the codegen instance id. Before IMPALA-4080 (f2837e9), we used fragment instance id as the codegen id. After that, since codegen is done in fragment level (shared by fragment instances), we use query id instead. This introduces conflicts between different fragments. The asm files will be overwritten. The same conflict happens in dumping IR modules (when unopt_module_dir or opt_module_dir is set). This changes the codegen instance id to be "QueryID_FragmentName_PID". The PID suffix is needed since we usually have several impalads running together on our dev box. Also adds logs when IR or disassembly are dumped to files. It helps to know which instance performs the codegen. Tests: - Manually verified the asm file names are expected. Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31 Reviewed-on: http://gerrit.cloudera.org:8080/19505 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/codegen/codegen-symbol-emitter.cc M be/src/codegen/llvm-codegen.cc M be/src/runtime/fragment-state.cc 3 files changed, 11 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31 Gerrit-Change-Number: 19505 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
