Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19589 )
Change subject: IMPALA-11974: Fix lazy list operators for Python 3 compatibility ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19589/2/testdata/bin/rewrite-iceberg-metadata.py File testdata/bin/rewrite-iceberg-metadata.py: http://gerrit.cloudera.org:8080/#/c/19589/2/testdata/bin/rewrite-iceberg-metadata.py@101 PS2, Line 101: metadata['snapshots'] = list(map(add_prefix_to_snapshot, metadata['snapshots'])) Probably could all be list comprehensions. But this works too. http://gerrit.cloudera.org:8080/#/c/19589/2/tests/comparison/query_profile.py File tests/comparison/query_profile.py: http://gerrit.cloudera.org:8080/#/c/19589/2/tests/comparison/query_profile.py@494 PS2, Line 494: filtered_signatures = list(filter( Doesn't this use of filter require an import from builtins? http://gerrit.cloudera.org:8080/#/c/19589/2/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/19589/2/tests/query_test/test_sort.py@30 PS2, Line 30: l > flake8: E741 ambiguous variable name 'l' Still doesn't like this variable. -- To view, visit http://gerrit.cloudera.org:8080/19589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c082711f8eff451a1b5c085e97461c327edb5f Gerrit-Change-Number: 19589 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 07 Mar 2023 21:57:11 +0000 Gerrit-HasComments: Yes
