Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19583 )
Change subject: IMPALA-11970: Add query timeline display to Impala WebUI ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19583/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/19583/2/be/src/service/impala-http-handler.cc@190 PS2, Line 190: query_timing > nit: I think "query_timeline" sounds better, but I'm fine either way. Updated all timing references to timeline http://gerrit.cloudera.org:8080/#/c/19583/2/be/src/service/impala-http-handler.cc@343 PS2, Line 343: ss.str(Substitute("Could not obtain runtime profile: $0", status.GetDetail())); > Should we set ss with just status.GetDetail() if status is not ok when call Done -- To view, visit http://gerrit.cloudera.org:8080/19583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5826107af0f5a7fe306cb986a875cff261d9db Gerrit-Change-Number: 19583 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 08 Mar 2023 03:41:10 +0000 Gerrit-HasComments: Yes
