Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19591
to look at the new patch set (#3).
Change subject: IMPALA-11976: Fix use of deprecated functions/fields removed in
Python 3
......................................................................
IMPALA-11976: Fix use of deprecated functions/fields removed in Python 3
Python 3 moved several things around or removed deprecated
functions / fields:
- sys.maxint was removed, but sys.maxsize provides similar functionality
- long was removed, but int provides the same range
- file() was removed, but open() already provided the same functionality
- Exception.message was removed, but str(exception) is equivalent
- Some encodings (like hex) were moved to codecs.encode()
- string.letters -> string.ascii_letters
- string.lowercase -> string.ascii_lowercase
- string.strip was removed
This fixes all of those locations. Python 3 also has slightly different
rounding behavior from round(), so this changes round() to use future's
builtins.round() to get the Python 3 behavior.
This fixes the following pylint warnings:
- file-builtin
- long-builtin
- invalid-str-codec
- round-builtin
- deprecated-string-function
- sys-max-int
- exception-message-attribute
Testing:
- Ran cores tests
Change-Id: I094cd7fd06b0d417fc875add401d18c90d7a792f
---
M bin/banned_py3k_warnings.txt
M bin/parse-thrift-profile.py
M docker/setup_build_context.py
M lib/python/impala_py_lib/gdb/impala-gdb.py
M testdata/bin/wait-for-hiveserver2.py
M testdata/bin/wait-for-metastore.py
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
M tests/common/kudu_test_suite.py
M tests/comparison/cluster.py
M tests/comparison/discrepancy_searcher.py
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_frontend_connection_limit.py
M tests/custom_cluster/test_hs2_fault_injection.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_restart_services.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/performance/query_exec_functions.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_query_mem_limit.py
M tests/query_test/test_scanners_fuzz.py
M tests/shell/test_shell_interactive.py
M tests/stress/concurrent_select.py
M tests/stress/query_runner.py
M tests/unittests/test_file_parser.py
M tests/unittests/test_result_verifier.py
27 files changed, 64 insertions(+), 53 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/19591/3
--
To view, visit http://gerrit.cloudera.org:8080/19591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094cd7fd06b0d417fc875add401d18c90d7a792f
Gerrit-Change-Number: 19591
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
