Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19590 )
Change subject: IMPALA-11975: Fix Dictionary methods to work with Python 3 ...................................................................... IMPALA-11975: Fix Dictionary methods to work with Python 3 Python 3 made the main dictionary methods lazy (items(), keys(), values()). This means that code that uses those methods may need to wrap the call in list() to get a list immediately. Python 3 also removed the old iter* lazy variants. This changes all locations to use Python 3 dictionary methods and wraps calls with list() appropriately. This also changes all itemitems(), itervalues(), iterkeys() locations to items(), values(), keys(), etc. Python 2 will not use the lazy implementation of these, so there is a theoretical performance impact. Our python code is mostly for tests and the performance impact is minimal. Python 2 will be deprecated when Python 3 is functional. This addresses these pylint warnings: dict-iter-method dict-keys-not-iterating dict-values-not-iterating Testing: - Ran core tests Change-Id: Ie873ece54a633a8a95ed4600b1df4be7542348da Reviewed-on: http://gerrit.cloudera.org:8080/19590 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M bin/banned_py3k_warnings.txt M bin/load-data.py M bin/start-impala-cluster.py M testdata/bin/generate-schema-statements.py M tests/beeswax/impala_beeswax.py M tests/common/impala_cluster.py M tests/common/impala_connection.py M tests/common/impala_test_suite.py M tests/comparison/common.py M tests/comparison/leopard/impala_docker_env.py M tests/comparison/query_generator.py M tests/comparison/query_profile.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_breakpad.py M tests/performance/workload.py M tests/query_test/test_cancellation.py M tests/query_test/test_decimal_fuzz.py M tests/query_test/test_insert_parquet.py M tests/query_test/test_kudu.py M tests/run-tests.py M tests/stress/concurrent_select.py M tests/stress/extract_min_mem.py M tests/stress/queries.py M tests/stress/query_runner.py M tests/stress/runtime_info.py 25 files changed, 60 insertions(+), 55 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie873ece54a633a8a95ed4600b1df4be7542348da Gerrit-Change-Number: 19590 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
