Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19521 )
Change subject: IMPALA-11927: Enable frame pointers for snappy and lz4 ...................................................................... IMPALA-11927: Enable frame pointers for snappy and lz4 Adds the -fno-omit-frame-pointer flag while compiling snappy and lz4. These two libs are used in many different code paths, e.g. snappy decompression is used in several code paths of late materialization, lz4 is used to compress row batches in KRPC sender. In perf investigation, the flame graphs make more sense with them enabled. Tests: - Ran perf test on TPCH. No significant perf change is detected. Change-Id: Ice7d767e42a90327ddede53ff6c55f17de05cf52 Reviewed-on: http://gerrit.cloudera.org:8080/19521 Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Quanlong Huang <[email protected]> --- M source/lz4/build.sh M source/snappy/build.sh 2 files changed, 13 insertions(+), 5 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Quanlong Huang: Verified -- To view, visit http://gerrit.cloudera.org:8080/19521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice7d767e42a90327ddede53ff6c55f17de05cf52 Gerrit-Change-Number: 19521 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
