Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19475 )
Change subject: IMPALA-11886: Data cache should support asynchronous writes ...................................................................... Patch Set 10: Code-Review+1 (2 comments) This is looking good. I only have a couple small things, then I think we are good to go. I will kick off another round of tests. Thank you for your patience on this review. http://gerrit.cloudera.org:8080/#/c/19475/10/be/src/runtime/io/data-cache-test.cc File be/src/runtime/io/data-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/19475/10/be/src/runtime/io/data-cache-test.cc@107 PS10, Line 107: usleep(10 * 1000); One small thing: Since we call this so frequently, it matters a lot to execution time of these tests. In my experiments, these tests run much faster if we bring this down to 500 vs 10000. http://gerrit.cloudera.org:8080/#/c/19475/10/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/19475/10/be/src/runtime/io/data-cache.cc@960 PS10, Line 960: if (buffer_limit < (1 << 23 /* 8MB */)) { : return Status(Substitute("Configured data cache write buffer limit $0 is too small " : "(less than 8MB)", FLAGS_data_cache_async_write_buffer_limit)); : } Unfortunately, this causes problems for the OutOfWriteBufferLimit test case, because it uses a smaller buffer. As a workaround, let's disable this check for backend tests: if (!TestInfo::is_be_test() && buffer_limit < (1 << 23 /* 8MB */)) { -- To view, visit http://gerrit.cloudera.org:8080/19475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I878f7486d485b6288de1a9145f49576b7155d312 Gerrit-Change-Number: 19475 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 21 Mar 2023 21:13:17 +0000 Gerrit-HasComments: Yes
