Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19643 )

Change subject: IMPALA-12014 warning on failed KeepAlive for Kudu scanner
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19643/1/be/src/exec/kudu/kudu-scanner.cc
File be/src/exec/kudu/kudu-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/19643/1/be/src/exec/kudu/kudu-scanner.cc@111
PS1, Line 111:     LOG(WARNING) << BuildErrorString(
> That makes sense to me.
Thank you for review!

I updated the patch to have KLOG_EVERY_N_SECS(WARNING, 60) instead of 
LOG(WARNING).  With that, the risk of the possible message flood should be 
addressed.  Meanwhile, it might still provide a clue for troubleshooting failed 
queries.



--
To view, visit http://gerrit.cloudera.org:8080/19643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If39f968685797506491d3d5ebc481efb6e43a568
Gerrit-Change-Number: 19643
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Tue, 21 Mar 2023 21:33:33 +0000
Gerrit-HasComments: Yes

Reply via email to