Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 )
Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set ...................................................................... Patch Set 4: (2 comments) Test failure was due flaky IMPALA-11968 and one bug in this patch. I'll try rebase to avoid the flaky test. http://gerrit.cloudera.org:8080/#/c/19645/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19645/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2107 PS4, Line 2107: group_set.getExec_group_name_prefix() Just figure out that this might be null. This precondition can be skipped if default_executor_group == true. http://gerrit.cloudera.org:8080/#/c/19645/4/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19645/4/tests/custom_cluster/test_executor_groups.py@792 PS4, Line 792: # Force to run the large query on the small group should fail This test now success since exec group memory limit is ignored. -- To view, visit http://gerrit.cloudera.org:8080/19645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14bf7fe71e2dda1099651b3edf62480e1fdbf845 Gerrit-Change-Number: 19645 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 23 Mar 2023 03:32:12 +0000 Gerrit-HasComments: Yes
