Hello Andrew Sherman, Kurt Deschler, Abhishek Rawat, Wenzhe Zhou, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19663
to look at the new patch set (#3).
Change subject: IMPALA-12032: Fix min parallelism bug in PlanFragment
......................................................................
IMPALA-12032: Fix min parallelism bug in PlanFragment
PROCESSING_COST_MIN_THREADS suppose to be a lower bound of per-node
parallelism when CPU costing algorithm adjust fragment parallelism
across executor group set. But PlanFragment.adjustToMaxParallelism() did
not take account of it during adjustment.
This patch fix that bug by capping per-node fragment parallelism to
PROCESSING_COST_MIN_THREADS if cost based parallelism comes up with
number that is lower.
Testing:
- Set PROCESSING_COST_MIN_THREADS in PlannerTest.testProcessingCost.
- Pass test_executor_groups.py.
- Add test cases in query-options-test.cc.
Change-Id: I6e58d5d54f60818c003f488b1681b8660552f1e9
---
M be/src/service/query-options-test.cc
M fe/src/main/java/org/apache/impala/planner/CostingSegment.java
M fe/src/main/java/org/apache/impala/planner/PlanFragment.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds-processing-cost.test
5 files changed, 451 insertions(+), 430 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/19663/3
--
To view, visit http://gerrit.cloudera.org:8080/19663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e58d5d54f60818c003f488b1681b8660552f1e9
Gerrit-Change-Number: 19663
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
