Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19664 )
Change subject: IMPALA-12033: Impalad crashes when --dump_exec_request_path is used ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/runtime/descriptors.cc@822 PS1, Line 822: std::ostream& operator<<(std::ostream& out, const TDescriptorTableSerialized& serial_tbl) { > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/runtime/descriptors.cc@825 PS1, Line 825: if (DescriptorTbl::DeserializeThrift(serial_tbl, &desc_tbl).ok()) { > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/runtime/descriptors.cc@828 PS1, Line 828: const uint8_t* p = reinterpret_cast<const uint8_t*>(serial_tbl.thrift_desc_tbl.data()); > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/service/impala-server.cc@1175 PS1, Line 1175: string fn(Substitute("$0/TExecRequest-$1.$2", FLAGS_dump_exec_request_path, This was the primary source of the crash. It is unclear how this ever worked. http://gerrit.cloudera.org:8080/#/c/19664/1/be/src/service/impala-server.cc@1179 PS1, Line 1179: std::string s = tmpstr.str(); : const char *p = s.c_str(); : const int len = s.length() > Is this the second bug fixing mentioned in the commit message? Just curious Yes. The memory returned by tmpstr.str.c_str() had garbage in it after assignment. The string copy that was returned must have gone out of scope. -- To view, visit http://gerrit.cloudera.org:8080/19664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I217f360a7df4fc1d3c0d0ae8af8d738a56356935 Gerrit-Change-Number: 19664 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Mar 2023 11:51:47 +0000 Gerrit-HasComments: Yes
