Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19691 )
Change subject: IMPALA-12041: Select first executor group if query not auto-scalable ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@9 PS1, Line 9: queri > Nit: queries? Done http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@11 PS1, Line 11: e > nit: the Done http://gerrit.cloudera.org:8080/#/c/19691/1//COMMIT_MSG@11 PS1, Line 11: fix > Nit: fixes Done http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19691/1/tests/custom_cluster/test_executor_groups.py@914 PS1, Line 914: self.execute_query_expect_success(self.client, "SET ENABLE_REPLAN='';") > Shouldn't we re-enable ENABLE_REPLAN after this query so this config doesn' This is unsetting ENABLE_REPLAN option, which has default value True. So subsequent testcases after this will have ENABLE_REPLAN=true, just like the testcases before this. -- To view, visit http://gerrit.cloudera.org:8080/19691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89497c8f67bfd176c2b60fa1b70fe53f905bbab0 Gerrit-Change-Number: 19691 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 12:39:21 +0000 Gerrit-HasComments: Yes
