Hello Andrew Sherman, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19683
to look at the new patch set (#2).
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
IMPALA-12037: Update Chart.js to 2.9.4
Updates Chart.js to 2.9.4 for bug fixes and to avoid prototype
pollution. Added Chart.min.js from
https://github.com/chartjs/Chart.js/releases/tag/v2.9.4. Moment.js from
bundle does not seem to be needed.
Chart.js 2.8 introduced https://github.com/chartjs/Chart.js/issues/6154,
which causes the last X-axis label with "and above" to always be
omitted. Add a custom autofit function to calculate our own spacing.
Testing:
- Examined /admission page with multiple queries admitted. Graph appears
to render correctly.
Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
---
D www/Chart-2.7.3.min.js
A www/Chart-2.9.4.min.js
M www/admission_controller.tmpl
3 files changed, 48 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/19683/2
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
