Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities ...................................................................... Patch Set 29: (1 comment) http://gerrit.cloudera.org:8080/#/c/18023/29/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/18023/29/fe/src/main/java/org/apache/impala/analysis/Expr.java@1064 PS29, Line 1064: if (! predicateHintValid(this)) { > Sorry I didn't understand what you mean, can you show me the detail modific Consider Expr.isTriviallyTrue() for example in the same file. That currently considers all of the Exprs returned by getConjuncts. Now if you have a hint, it is going to not consider the child conjuncts. I don't know if that will be be correct still. If nothing else it is hard to follow and a risk for future bugs. There are multiple other caller in analyzer that I did not look at. My suggestion would be to not change the existing getConjuncts() or any logic that is calls. Instead, make a new function getLocalConjuncts and conditionally call that from where you need to after determining that the conditional calls will not adversely affect correctness or other optimizations. -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 29 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 10 Apr 2023 14:09:23 +0000 Gerrit-HasComments: Yes
