Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19708 )
Change subject: IMPALA-12045: Strip ANSI escape sequences for JUnitXML ...................................................................... IMPALA-12045: Strip ANSI escape sequences for JUnitXML ANSI escape sequences do a variety of actions in the terminal like adding color to compilation warnings. generate_junitxml.py currently hits an error when trying to generate JUnitXML for compilation output that contains ANSI escape sequences. This changes generate_junitxml.py to strip ANSI escape sequences from the strings incorporated into JUnitXML (e.g. the error output of a compiler). The solution is based off the discussion at: https://stackoverflow.com/questions/14693701 Testing: - A case where generate_junitxml.py was failing to generate JUnitXML now generates valid JUnitXML. The output still contains all the compiler warnings and information needed to diagnose the issue. Change-Id: I9654a6b13350cb9582ec908b8807b630636a1ed0 Reviewed-on: http://gerrit.cloudera.org:8080/19708 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M lib/python/impala_py_lib/jenkins/generate_junitxml.py 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Wenzhe Zhou: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9654a6b13350cb9582ec908b8807b630636a1ed0 Gerrit-Change-Number: 19708 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
