Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19712 )
Change subject: IMPALA-12043: Fix "MaxMessageSize reached" exception in Thrift JNI ...................................................................... Patch Set 4: (7 comments) Patch set 4 run clang-format to fix line too long warnings. http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/TConfiguration.java File fe/src/compat-apache-hive-3/java/org/apache/thrift/TConfiguration.java: http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/TConfiguration.java@24 PS3, Line 24: public static final int DEFAULT_MAX_FRAME_SIZE = 16384000; > line too long (130 > 90) Done http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java File fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java: http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java@58 PS3, Line 58: remainingMessageSize = newSize; > line too long (101 > 90) Done http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java@65 PS3, Line 65: * @param size > line too long (100 > 90) Done http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java@66 PS3, Line 66: */ > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java@76 PS3, Line 76: * @param numBytes > line too long (107 > 90) Done http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java@81 PS3, Line 81: TTransportException.END_OF_FILE, "MaxMessageSize reached"); > line too long (101 > 90) Done http://gerrit.cloudera.org:8080/#/c/19712/3/fe/src/compat-apache-hive-3/java/org/apache/thrift/transport/TEndpointTransport.java@96 PS3, Line 96: } > line too long (101 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/19712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I105db332cd312d80bac0313090576bc47064ee16 Gerrit-Change-Number: 19712 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Apr 2023 00:18:01 +0000 Gerrit-HasComments: Yes
