Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )
Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py File bin/collect_minidumps.py: http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py@28 PS1, Line 28: from builtins import range "builtins" is a library provided by the PyPi future package, so it isn't installed by default with plain Python. For this particular script, I'm not sure PyPi future will be installed consistently, and we don't want to have problems because it isn't installed. I think the other option is to just use "range" without this import. On python2 it is less efficient, but that only comes up if it is constructing a very large list. -- To view, visit http://gerrit.cloudera.org:8080/19727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe Gerrit-Change-Number: 19727 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 13 Apr 2023 16:23:08 +0000 Gerrit-HasComments: Yes
