Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19751 )
Change subject: IMPALA-12066: Avoid missing updates due to skipping ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/19751/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19751/5//COMMIT_MSG@20 PS5, Line 20: catalog_max_lock_delay_topic_updates The name doesn't indicate this is a duration, not a count. "catalog_topic_update_max_lock_delay_ms" might be better. The "_ms" suffix indicates it's a duration in milliseconds. http://gerrit.cloudera.org:8080/#/c/19751/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/19751/5/be/src/catalog/catalog-server.cc@135 PS5, Line 135: 240000 How do we determine the value of this? Is it based on topic_update_tbl_max_wait_time_ms and catalog_max_lock_skipped_topic_updates? If so, can we calcuate it directly from them? http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1512 PS5, Line 1512: new Date().getTime() System.currentTimeMillis() is better http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1545 PS5, Line 1545: new Date().getTime() System.currentTimeMillis() is better http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1549 PS5, Line 1549: tbl.getFullName(), tbl.getCatalogVersion(), ctx.fromVersion, ctx.toVersion); Please also add "delay" in the log. http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1553 PS5, Line 1553: topicUpdateLog_.getOrCreateLogEntry(tableUniqueName); nit: merge line 1552 and 1553 into one line -- To view, visit http://gerrit.cloudera.org:8080/19751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a21edaea21b95723e567ddee5e1f857c0e2b087 Gerrit-Change-Number: 19751 Gerrit-PatchSet: 5 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 19 Apr 2023 03:26:30 +0000 Gerrit-HasComments: Yes
