Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19755 )
Change subject: IMPALA-12069: Remove BUILD_HISTORICAL option ...................................................................... IMPALA-12069: Remove BUILD_HISTORICAL option The BUILD_HISTORICAL option hasn't worked in a long time, and it clutters the codebase with build code and patches for old versions. This change removes the BUILD_HISTORICAL option and all patches for old versions of components. It also retires some old build logic for old versions. For example, older versions of Snappy used autotools, but Snappy switched to CMake. This cleans up the build script, removing the old autotools logic. This applies to other components as well. This removes a couple locations of out of date OS-X darwin logic, where darwin is referencing an old version of a component that is clearly useless to modern Impala. Testing: - Ran a toolchain build Change-Id: Ib2df0af087af14f57e80b5ed94879bd1434501d4 Reviewed-on: http://gerrit.cloudera.org:8080/19755 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M README.md M buildall.sh M init-compiler.sh M init.sh D source/binutils/binutils-2.26-patches/0001-Store-estimated-istrances-in-compressed_size.patch D source/boost/boost-1.57.0-patches/0001-greg-year-range.patch D source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch D source/boost/boost-1.57.0-patches/0003-cpp-int-missing-casts.patch D source/boost/boost-1.61.0-patches/0001-greg-year-range.patch D source/boost/boost-1.61.0-patches/0002-IMPALA-5357.patch D source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch D source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch D source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0003-fix-md2core.patch D source/breakpad/breakpad-20150612-patches/0001-breakpad-patch-makefile-in-for-issue-633.diff D source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch D source/breakpad/breakpad-88e5b2c8806bac3f2c80d2fe80094be5bd371601-patches/0002-Increase-maximum-number-of-threads-for-minidump_stac.patch D source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch D source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0002-Build-breakpad-97a98836-on-ppc64le.patch D source/breakpad/breakpad-ffe3e478657dc7126fca6329dfcedc49f4c726d9-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch D source/breakpad/breakpad-ffe3e478657dc7126fca6329dfcedc49f4c726d9-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch D source/bzip2/bzip2-1.0.6-patches/001-adjust-makefile-to-env-variables.diff D source/bzip2/bzip2-1.0.6-patches/002-directoryless-executable-symlinks.diff D source/cmake/cmake-3.2.3-patches/0001-IMPALA-3191.patch D source/cmake/cmake-3.8.2-patches/0001-IMPALA-3191.patch D source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0001-Build-crcutil-440ba7b-on-ppc64le.patch D source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0002-Build-crcutil-440ba7b-on-aarch64.patch M source/gcc/build.sh D source/gcc/gcc-4.9.2-patches/132-build_gcc-5_with_gcc-6.patch D source/gcc/gcc-4.9.2-patches/942-asan-fix-missing-include-signal-h.patch D source/gcc/gcc-4.9.2-patches/943-Use-ucontext_t-not-struct-ucontext-in-linux-unwind.h.patch D source/gcc/gcc-4.9.2-patches/944-sanitizer-linux.patch D source/gcc/gcc-4.9.2-patches/945-ustat.patch D source/gcc/gcc-7.5.0-patches/0001-PATCH-glibc-2.31-libsanitizer.patch D source/gcc/manual_patches_gcc-4.9.2/gmp.patch D source/gdb/gdb-7.9.1-patches/0001-Based-on-https-sourceware.org-ml-gdb-patches-2016-08.patch D source/glog/glog-0.3.2-patches/0001-Allow-glog-to-accept-a-message-listener.patch D source/glog/glog-0.3.2-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch D source/glog/glog-0.3.3-patches/glog-issue-198-fix-unused-warnings.patch D source/glog/glog-0.3.4-patches/0001-Allow-glog-to-accept-a-message-listener.patch D source/glog/glog-0.3.4-patches/0002-Preserve-custom-signal-handler-for-dcheck.patch D source/glog/glog-0.3.4-patches/0003-rate-limit-calls-to-posix_fadvise.patch D source/gperftools/gperftools-2.0-patches/0001-Fixing-invalid-type-conversions-on-some-s.patch D source/kudu/kudu-cdh5-1.2.0_5.10.0-rc1-patches/0001-CDH-48124.patch D source/libunwind/libunwind-1.3-rc1-patches/0001-libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch D source/libunwind/libunwind-1.3-rc1-patches/0002-libunwind-trace-cache-destructor.patch D source/libunwind/libunwind-1.3-rc1-patches/0003-Fix-Build-On-Centos-5-Without-pipe2.patch D source/llvm/build-3.3.sh M source/llvm/build-source-tarball.sh M source/llvm/build.sh D source/llvm/llvm-3.3-patches/mac-os-x.patch D source/llvm/llvm-3.8.0-patches/0001-llvm-link-struct-types.patch D source/llvm/llvm-3.9.1-patches/0001-llvm-link-struct-types.patch M source/lz4/build.sh M source/orc/build.sh D source/orc/orc-1.4.3-patches/0001-Allow-building-against-external-versions-of-dependen.patch D source/orc/orc-1.4.3-patches/0002-ORC-239.-Install-missing-Statistics.hh-header-file.patch D source/orc/orc-1.4.3-patches/0003-disable-Werror.patch D source/orc/orc-1.5.2-patches/0001-ORC-396-also-look-for-LZ4-libs-in-lib64-subdir.patch D source/orc/orc-1.5.2-patches/0002-ORC-403-C-Add-checks-to-avoid-invalid-offsets-in-Inp.patch D source/orc/orc-1.5.5-patches/0001-ORC-396-also-look-for-LZ4-libs-in-lib64-subdir.patch D source/orc/orc-1.6.2-patches/0001-ORC-580-C-Verify-ColumnEncodings-in-StripeFooter-463.patch D source/orc/orc-1.6.2-patches/0002-ORC-581-C-Verify-fieldNames-size-for-STRUCT-types.patch D source/orc/orc-1.6.2-patches/0003-ORC-586-C-fix-memory-leak-in-StructColumnReader.patch D source/orc/orc-1.6.2-patches/0004-ORC-589-C-add-checks-about-negative-dictionary-entry.patch D source/orc/orc-1.6.2-patches/0005-ORC-590-C-added-check-for-missing-LENGTH-stream-in-S.patch D source/orc/orc-1.6.2-patches/0006-ORC-591-C-Check-missing-blob-stream-for-StringDictio.patch D source/orc/orc-1.6.2-patches/0007-ORC-600-Fix-StringDictionaryColumnReader-to-update-i.patch D source/orc/orc-1.6.2-patches/0008-ORC-763-C-Fix-ORC-timestamp-inconsistencies-with-Jav.patch D source/orc/orc-1.6.2-patches/0009-ORC-784-C-Support-setting-timezone-to-timestamp-colu.patch D source/orc/orc-1.6.2-patches/0010-ORC-666-C-Support-timestamp-with-local-timezone.patch D source/orc/orc-1.6.2-patches/0011-ORC-781-C-Make-type-annotations-available-from-C.patch D source/re2/re2-20130115-patches/0001-Expose-dotnl-as-part-of-re2.patch M source/snappy/build.sh D source/thrift/thrift-0.13.0-patches/0001-TLS-forward-compatibility.patch D source/thrift/thrift-0.13.0-patches/0002-THRIFT-2087-Python-compiler-replace-non-utf-8-char-w.patch D source/thrift/thrift-0.13.0-patches/0003-THRIFT-5303-Fix-missing-error-handling-in-using-PyUn.patch D source/thrift/thrift-0.13.0-patches/0004-IMPALA-11195-Disable-SSL-renegotiations.patch D source/thrift/thrift-0.14.2-patches/0001-TLS-forward-compatibility.patch D source/thrift/thrift-0.14.2-patches/0002-IMPALA-11195-Disable-SSL-renegotiations.patch D source/thrift/thrift-0.14.2-patches/0003-THRIFT-5418-Fix-missing-implementation-for-enum-func.patch D source/thrift/thrift-0.14.2-patches/0004-Fix-Thread-destructor-sigsegv-when-uninitialized.patch D source/thrift/thrift-0.9.0-patches/0001-revert-thrift-1773.patch D source/thrift/thrift-0.9.0-patches/0002-fix-thrift-union.patch D source/thrift/thrift-0.9.0-patches/0003-fix-compile-warnings.patch D source/thrift/thrift-0.9.0-patches/0004-CDH-30961-Allow-Thrift-to-accept-TLSv1.1-and-v1.2.patch D source/thrift/thrift-0.9.0-patches/0005-IMPALA-3159-Add-SAN-Wildcard-SSL-cert-client-support-in-python.patch D source/thrift/thrift-0.9.0-patches/0006-Revert-Thrift-p5_IMPALA-3159-Add-SAN-Wildcard-SSL-cert-client-support-in-python.patch D source/thrift/thrift-0.9.0-patches/0007-IMPALA-3494-fix-Thrift-TMemoryBuffer-overflow.patch D source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-THRIFT-2021-string-buffer-memory.patch D source/thrift/thrift-0.9.0-patches/0009-THRIFT-2201-Ternary-operator-returns-different-types.patch D source/thrift/thrift-0.9.0-patches/0010-THRIFT-2258-Add-TLS-configuration.patch D source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch D source/thrift/thrift-0.9.0-patches/0012-THRIFT-3878-fix-interop-with-newer-OpenSSL-libraries.patch D source/thrift/thrift-0.9.2-patches/0001-316-add-openssl.patch D source/thrift/thrift-0.9.2-patches/0002-337-libevent-optional.patch D source/thrift/thrift-0.9.2-patches/0003-THRIFT-3736-C-library-build-fails-if-OpenSSL-does-no.patch D source/thrift/thrift-0.9.2-patches/0004-THRIFT-3878-fix-interop-with-newer-OpenSSL-libraries.patch D source/thrift/thrift-0.9.3-patches/0001-THRIFT-3650.patch D source/thrift/thrift-0.9.3-patches/0002-reomve-twisted-pyton-dependency.patch D source/thrift/thrift-0.9.3-patches/0003-THRIFT-3505.patch D source/thrift/thrift-0.9.3-patches/0004-TLS-forward-compatibility.patch D source/thrift/thrift-0.9.3-patches/0005-THRIFT-3878-fix-interop-with-newer-OpenSSL-libraries.patch D source/thrift/thrift-0.9.3-patches/0006-remove-misleading-deprecation-warning.patch D source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch D source/thrift/thrift-0.9.3-patches/0008-remove-duplicated-host-header.patch 105 files changed, 41 insertions(+), 10,988 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Wenzhe Zhou: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/19755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib2df0af087af14f57e80b5ed94879bd1434501d4 Gerrit-Change-Number: 19755 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
