Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19771 )
Change subject: IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail ...................................................................... IMPALA-12074: Add the WARN_UNUSED_RESULT attribute to methods of BitWriter that can fail Many methods of BitWriter signal failure via the return value. These return values should not be discarded because the failures are not detected then. This change adds the 'WARN_UNUSED_RESULT' attribute to these methods so the compiler can check that the return value is not discarded. Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae Reviewed-on: http://gerrit.cloudera.org:8080/19771 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/parquet/parquet-bool-decoder.cc M be/src/util/bit-stream-utils-test.cc M be/src/util/bit-stream-utils.h M be/src/util/rle-encoding.h M be/src/util/rle-test.cc 5 files changed, 21 insertions(+), 13 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I97ddba8057f71b6ebbed5b89b12d81c659ce98ae Gerrit-Change-Number: 19771 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]>
