Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19744 )
Change subject: IMPALA-11970: Optimized rendering for the query timeline display ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/19744/9/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/9/www/query_timeline.tmpl@128 PS9, Line 128: plan_order = document.getElementById("plan_order").checked; It seems checkbox "Print tree in plan order" is not working now. When the box is checked, renderTiming() will be called, but collectFromProfile() is not called. So this line should be moved to beginning of renderTiming() function. -- To view, visit http://gerrit.cloudera.org:8080/19744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec458602266863b6e313f52b26a2dc35cff0db0f Gerrit-Change-Number: 19744 Gerrit-PatchSet: 9 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 20 Apr 2023 18:24:24 +0000 Gerrit-HasComments: Yes
