Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally ...................................................................... Patch Set 1: (2 comments) This makes sense to me, just some minor nits http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py File tests/metadata/test_recover_partitions.py: http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@181 PS1, Line 181: SRC_DIR = os.path.join("/tmp", unique_database, TBL_NAME) : if not os.path.exists(SRC_DIR): : os.makedirs(SRC_DIR) Nit: Different approach would be to delete the directory if it already exists, then start from scratch. http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@190 PS1, Line 190: self.filesystem_client.copy_from_local(SRC_DIR, DB_LOCATION) Let's cleanup the temp directory after this. -- To view, visit http://gerrit.cloudera.org:8080/19782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e Gerrit-Change-Number: 19782 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 21 Apr 2023 22:47:18 +0000 Gerrit-HasComments: Yes
