Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19697 )
Change subject: IMPALA-9627: Update utility scripts for Python 3 (part 2) ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/19697/14/bin/push_to_asf.py File bin/push_to_asf.py: http://gerrit.cloudera.org:8080/#/c/19697/14/bin/push_to_asf.py@66 PS14, Line 66: def confirm_prompt(prompt): : """ : Issue the given prompt, and ask the user to confirm yes/no. Returns true : if the user confirms. : """ : while True: : print(prompt, "[Y/n]:", end=' ') : : if not os.isatty(sys.stdout.fileno()): : print("Not running interactively. Assuming 'N'.") : return False : : r = input().strip().lower() : if r in ['y', 'yes', '']: : return True : elif r in ['n', 'no']: : return False > Sounds like a good idea to me. Done -- To view, visit http://gerrit.cloudera.org:8080/19697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idff388aff33817b0629347f5843ec34c78f0d0cb Gerrit-Change-Number: 19697 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 21 Apr 2023 23:24:40 +0000 Gerrit-HasComments: Yes
