Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19547 )

Change subject: IMPALA-11950: Planner change for Iceberg metadata querying
......................................................................


Patch Set 5:

(1 comment)

Thank you for the reviews!

http://gerrit.cloudera.org:8080/#/c/19547/5/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java
File fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java:

http://gerrit.cloudera.org:8080/#/c/19547/5/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java@41
PS5, Line 41:     computeStats(analyzer);
> Is a metadata table has such a thing as stats? Does it make sense to comput
This will compute the average row sizes as well, so the plan can have better 
values, even though the actual statistics will not be used.



--
To view, visit http://gerrit.cloudera.org:8080/19547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3675d7a57ca570bfec306798589b5ef6aa34b5c6
Gerrit-Change-Number: 19547
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 24 Apr 2023 09:04:21 +0000
Gerrit-HasComments: Yes

Reply via email to