Peter Rozsa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19790 )
Change subject: IMPALA-12042: Invalid casts in set operations calculation ...................................................................... IMPALA-12042: Invalid casts in set operations calculation This change fixes invalid casts in set operations where the common type calculation fails to determine the incompatibility between 3 or more types. The previous solution does not check every possible combinations between types (nCr); the current approach provides a solution to this problem by grouping the available types in the statement's slots and reducing the available type set by calculating every combination until only one type remains or any type combination yield an invalid type. Tests: - new test case added to AnalyzeStmtTests Change-Id: I02df42c67deda37b7f71db267dc761778a9caa2b --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java A fe/src/main/java/org/apache/impala/analysis/SetCompatibilityHandler.java M fe/src/main/java/org/apache/impala/catalog/Type.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java 4 files changed, 212 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/19790/2 -- To view, visit http://gerrit.cloudera.org:8080/19790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I02df42c67deda37b7f71db267dc761778a9caa2b Gerrit-Change-Number: 19790 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]>
