Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19792 )
Change subject: IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19792/1/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: http://gerrit.cloudera.org:8080/#/c/19792/1/be/src/util/bit-util-test.cc@261 PS1, Line 261: 8; > nit: I think that 8 would be clearer for most Done http://gerrit.cloudera.org:8080/#/c/19792/1/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/19792/1/be/src/util/bit-util.h@313 PS1, Line 313: CHAR_BIT > I would prefer 8 We use CHAR_BIT in the 'CountTrailingZeros()' functions above, starting from 288. -- To view, visit http://gerrit.cloudera.org:8080/19792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ae3d84c5c25871388155747f91c51162c1a0590 Gerrit-Change-Number: 19792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 08:27:59 +0000 Gerrit-HasComments: Yes
