Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19804 )
Change subject: IMPALA-12099: Catalogd throw NPE when refreshing a partitioned table ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19804/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19804/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@697 PS1, Line 697: } For supportability, can we add a warning log when the partition name is null? We can print the required fields of CompactionInfoStruct and probably the 'errorMessage' if exists, or just dump the whole CompactionInfoStruct object. http://gerrit.cloudera.org:8080/#/c/19804/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@757 PS1, Line 757: } Same here, can we add a warning log when the partition name is null? -- To view, visit http://gerrit.cloudera.org:8080/19804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If37559f3c74ac517d1403ddb82ca28708015d6bf Gerrit-Change-Number: 19804 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 04:55:38 +0000 Gerrit-HasComments: Yes
