Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 )
Change subject: IMPALA-10798: Prototype a simple JSON File reader ...................................................................... Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json-parser.h File be/src/exec/json-parser.h: http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json-parser.h@334 PS4, Line 334: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.h File be/src/exec/json/hdfs-json-scanner.h: http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.h@123 PS4, Line 123: /// This is used to indicate whether an error has occurred in the currently parsed row. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.h@134 PS4, Line 134: /// JsonParse comment. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.h@138 PS4, Line 138: /// specific uses described in the JsonParse comment. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.cc File be/src/exec/json/hdfs-json-scanner.cc: http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.cc@42 PS4, Line 42: scanner_state_(CREATED), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.cc@202 PS4, Line 202: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.cc@221 PS4, Line 221: // due to BreakParse(). line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/be/src/exec/json/hdfs-json-scanner.cc@233 PS4, Line 233: // the parser that eos has been reached. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19699/4/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/19699/4/tests/query_test/test_scanners_fuzz.py@80 PS4, Line 80: a flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/19699/4/tests/query_test/test_tpch_queries.py File tests/query_test/test_tpch_queries.py: http://gerrit.cloudera.org:8080/#/c/19699/4/tests/query_test/test_tpch_queries.py@41 PS4, Line 41: s flake8: E501 line too long (96 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/19699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31309cb8f2d04722a0508b3f9b8f1532ad49a569 Gerrit-Change-Number: 19699 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 07:53:06 +0000 Gerrit-HasComments: Yes
