Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19776 )
Change subject: IMPALA-11877: (part 1) Add support for DELETE statements for UNPARTITIONED Iceberg tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19776/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19776/1//COMMIT_MSG@19 PS1, Line 19: from: : DELETE FROM ice_t WHERE id = 42; : : to: : INSERT INTO ice_t-POSITION-DELETE : SELECT INPUT__FILE__NAME, FILE__POSITION : FROM ice_t : WHERE id = 42; > This is a very important statement, thanks for your work Zoltan. Thanks Penglin for taking a look. I have a design doc about DELETE + UPDATE: https://docs.google.com/document/d/1GuRiJ3jjqkwINsSCKYaWwcfXHzbMrsd3WEMDOB11Xqw/edit#heading=h.5bmfhbmb4qdk So my plan is to reuse as much as I can of this work when I'm implementing the UPDATE. There will be some differences when I'll implement it for partitioned tables, because partition evolution introduces additional complexities. I'll update the design doc with the final solution once we have it implemented. -- To view, visit http://gerrit.cloudera.org:8080/19776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic933b2295abe54b46d2a736961219988ff42915b Gerrit-Change-Number: 19776 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 13:01:50 +0000 Gerrit-HasComments: Yes
