Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19811 )
Change subject: IMPALA-12097: WITH CLAUSE should be skipped when optimizing COUNT(*) query on Iceberg table ...................................................................... Patch Set 1: Code-Review+1 (3 comments) A few minor comments below. http://gerrit.cloudera.org:8080/#/c/19811/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19811/1//COMMIT_MSG@9 PS1, Line 9: start nit: 'star' instead of 'start' http://gerrit.cloudera.org:8080/#/c/19811/1//COMMIT_MSG@15 PS1, Line 15: * Add e2e tests Were you also planning to add a planner test for the WITH clause ? It would be useful to have 1 such test. http://gerrit.cloudera.org:8080/#/c/19811/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/19811/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1437 PS1, Line 1437: optimizePlainCountStarQuery nit: Since this function is specifically meant for Iceberg tables, can we rename this to optimizePlainCountStarQueryForIceberg() ? It is slightly verbose but makes the intent clearer to avoid confusion. -- To view, visit http://gerrit.cloudera.org:8080/19811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b21cbea79be77f2ea8490bd7f7b2f62063eb0e4 Gerrit-Change-Number: 19811 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 19:01:38 +0000 Gerrit-HasComments: Yes
