Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19812 )
Change subject: IMPALA-9627: Use universal_newlines for Python 3 ...................................................................... Patch Set 3: > Patch Set 3: Code-Review+1 > > I ran this compare_branches.py command it works fine with python2 and python3: > bin/compare_branches.py --source_remote_name origin --source_branch master > --target_remote_name origin --target_branch branch-4.1.1 > There are various committers with Unicode in their names, so that is a sanity > check. > > One small thing: I did "git grep -A2 check_output" > I see one or two check_output calls that might also need this: > bin/start-impala-cluster.py (stuff around docker port and docker network > inspect) > test/common/impala_cluster.py (stuff around docker network inspect) They're safe uses, but I can update them anyway. -- To view, visit http://gerrit.cloudera.org:8080/19812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3dae9113635cf23ae02f1f630de311e64119c456 Gerrit-Change-Number: 19812 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 28 Apr 2023 16:12:13 +0000 Gerrit-HasComments: No
