Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19207 )
Change subject: IMPALA-11603: Build against Cloudflare ZLIB by default ...................................................................... IMPALA-11603: Build against Cloudflare ZLIB by default Cloudflare Zlib is a fork of the Zlib codebase that has been optimized to take advantage of CPU SIMD instructions and other platform-specific optimizations. It has the same license as regular Zlib. Amazon has touted this as a major speedup over regular Zlib: https://aws.amazon.com/blogs/opensource/improving-zlib-cloudflare-and-comparing-performance-with-other-zlib-forks/ This adds the IMPALA_USE_CLOUDFLARE_ZLIB environment variable which allows Impala to be built against Cloudflare Zlib. This defaults to true. If set to any other value, it will build against regular Zlib. Cloudflare Zlib shows a clear performance benefit over regular Zlib on TPC-H ORC/deflate benchmark: +----------+-------------------+---------+------------+------------+----------------+ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +----------+-------------------+---------+------------+------------+----------------+ | TPCH(42) | orc / def / block | 4.18 | -6.43% | 3.29 | -6.74% | +----------+-------------------+---------+------------+------------+----------------+ Testing: - Ran GVO tests and exhaustive release tests Change-Id: I82c480890726da0fa5bdc2a646022554eec181f4 Reviewed-on: http://gerrit.cloudera.org:8080/19207 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> --- M CMakeLists.txt M bin/bootstrap_toolchain.py M bin/impala-config.sh 3 files changed, 18 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, but someone else must approve Wenzhe Zhou: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I82c480890726da0fa5bdc2a646022554eec181f4 Gerrit-Change-Number: 19207 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
