Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19830 )
Change subject: IMPALA-10585: Only retry SELECT queries ...................................................................... IMPALA-10585: Only retry SELECT queries Before this patch if retry_failed_queries=1 then DML queries were also retried if there were failed backends. This was not handled correctly in the coordinator and could lead to: - duplicate rows for external tables - incorrect transaction handling for Hive ACID tables Testing is also missing for DMLs + retry_failed_queries. This is a quick fix that disables retrying non-select statements. Followup commits can add more sophisticated handling and tests. Testing: - manually checked that INSERTs are not retried Change-Id: I7a0ae7994ad1dc82bfb5989c924c95b66ff81b81 Reviewed-on: http://gerrit.cloudera.org:8080/19830 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Michael Smith <[email protected]> --- M be/src/runtime/query-driver.cc 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Michael Smith: Verified -- To view, visit http://gerrit.cloudera.org:8080/19830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a0ae7994ad1dc82bfb5989c924c95b66ff81b81 Gerrit-Change-Number: 19830 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
