Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19798 )
Change subject: IMPALA-12100: Set REGISTER_INSTALL_PREFIX=Off for gflags build ...................................................................... Patch Set 2: > This makes sense. When I look at an environment that's built > native-toolchain before, I also see RaidJSON and yaml-cpp; we might > want to set this for them as well. I think yaml-cpp might be from the Kudu build. We can track that down. RapidJSON is odd, because it is header only and we just copy it over. I'm double checking the build on this, then I'll go forward. -- To view, visit http://gerrit.cloudera.org:8080/19798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I682ce40622f4bbad0c412de29006a3a9b4ae4765 Gerrit-Change-Number: 19798 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 04 May 2023 19:12:36 +0000 Gerrit-HasComments: No
