Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19840 )
Change subject: aarch64: use __atomic builtins instead of inline assembly ...................................................................... Patch Set 1: > > There's an initial effort Joe just shared at > > https://gerrit.cloudera.org/c/19185. > > He doesn't have bandwidth to finish it at the moment though. > > Thanks again Michael for the pointer. > I read through the changes and I agree with the 4 points listed by > Joe for remaining work. > In particular my patch goes against point 4: > > > 4. This has diverged quite a bit from the Chromium change > > So that's one more reason to finish the work from Joe's changes > instead of diverging even more due to my patch. > So -1 for my patch, and I will work on finishing > https://gerrit.cloudera.org/#/c/19185/ Thanks for looking at this. My patch for IMPALA-11694 required a variety of modifications from the original Chromium code. It was a mixture of adapting the code to work outside the Chromium codebase (random includes, etc), implement some atomic operations that Chromium doesn't need, and things like that. #4 is a mental note for myself to double-check what I changed compared to Chromium as a sanity check. -- To view, visit http://gerrit.cloudera.org:8080/19840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ee85e0ac438de42f16578801a35e6874f1a58bf Gerrit-Change-Number: 19840 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 00:18:03 +0000 Gerrit-HasComments: No
