Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19790 )
Change subject: IMPALA-12042: Fix invalid casts in set operations calculation ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19790/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19790/4//COMMIT_MSG@9 PS4, Line 9: This patch adds an additional type check for every expression > We could add the example from the Jira ticket. Done http://gerrit.cloudera.org:8080/#/c/19790/4/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19790/4/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3317 PS4, Line 3317: Type commonType = getCompatibleType(compatibleType, > We could check that this returns 'compatibleType' in a precondition check. Done -- To view, visit http://gerrit.cloudera.org:8080/19790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02df42c67deda37b7f71db267dc761778a9caa2b Gerrit-Change-Number: 19790 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 05 May 2023 15:26:02 +0000 Gerrit-HasComments: Yes
