Joe McDonnell has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/19839 )
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
IMPALA-12119: rename FORCE_INLINE to avoid name collision
Compiling impala on arm64 fails with an error of redefined FORCE_INLINE
preprocessor macro:
/home/spop/impala/be/src/util/sse2neon.h:48: error: "FORCE_INLINE" redefined
[-Werror]
48 | #define FORCE_INLINE static inline {}attribute{}((always_inline))
|
In file included from /home/spop/impala/be/src/codegen/llvm-codegen-cache.h:30,
from /home/spop/impala/be/src/runtime/exec-env.cc:27:
/home/spop/impala/be/src/thirdparty/datasketches/MurmurHash3.h:45: note: this
is the location of the previous definition
45 | #define FORCE_INLINE inline {}attribute{}((always_inline))
|
This patch renames FORCE_INLINE in MurmurHash3.h following the patch
in datasketches:
https://github.com/apache/datasketches-cpp/commit/0d8a17de0dc18493eb17e6613ad1534d6ff247b7
Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Reviewed-on: http://gerrit.cloudera.org:8080/19839
Reviewed-by: Daniel Becker <[email protected]>
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/thirdparty/datasketches/MurmurHash3.h
1 file changed, 24 insertions(+), 27 deletions(-)
Approvals:
Daniel Becker: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
