Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19837 )

Change subject: IMPALA-11880: Adds support for authenticating to Impala using 
JWTs.
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19837/9/tests/custom_cluster/test_shell_jwt_auth.py
File tests/custom_cluster/test_shell_jwt_auth.py:

http://gerrit.cloudera.org:8080/#/c/19837/9/tests/custom_cluster/test_shell_jwt_auth.py@206
PS9, Line 206: prometheus metrics
nit: impala_service.py::get_metric_value() read from web page /metrics, not 
/metrics_prometheus



--
To view, visit http://gerrit.cloudera.org:8080/19837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52247f9262c548946269fe5358b549a3e8c86d4c
Gerrit-Change-Number: 19837
Gerrit-PatchSet: 9
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 11 May 2023 17:33:53 +0000
Gerrit-HasComments: Yes

Reply via email to