Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19863 )
Change subject: PROTOTYPE IMPALA-11941: Support Java 17 in Impala ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19863/7/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/19863/7/bin/bootstrap_system.sh@231 PS7, Line 231: openjdk-1.8.0-jdk On Ubuntu this is openjdk-8-{jdk,source,dbg} I would also suggest adding a redhat option to keep bootstrap_system.sh working across all supported platforms. http://gerrit.cloudera.org:8080/#/c/19863/7/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/19863/7/testdata/bin/run-hive-server.sh@86 PS7, Line 86: amd64 this could break the ARM builds (unless this is only for an experiment, in which case it's fine) -- To view, visit http://gerrit.cloudera.org:8080/19863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic378896f572e030a3a019646a96a32a07866a737 Gerrit-Change-Number: 19863 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 21:03:41 +0000 Gerrit-HasComments: Yes
